Notifications not appearing

Hello.

I have reaction extension 1.0.4 and I have a problem with notifications..

1) Sometimes, the notification is not sent when a user reacts, sometimes it is sent correctly!

2) If I have a post where 15 people reacted, sometimes the notification will show only 10 people reacted..

I think there's a problem from add_notification but I'm not 100% sure.

The strange thing is, if I delete all reactions (as an admin) from a post where notifications are not sent when reacting, and react again - the notification is sent correctly!

What can be the cause and how can I fix it? Thank you!

[IvanPF]

Hi,

I have to try to reproduce that same mistake and do tests to find out the cause.
I currently do not have much free time, I will do it as soon as possible

Hi,

I have to try to reproduce that same mistake and do tests to find out the cause.
I currently do not have much free time, I will do it as soon as possible

So basically, I think there's a problem with how the user id feature is implemented.

Because I changed the add_notification with this one:

Code: Select all

public function add_notification($notification_type_name, $notification_data)
{
    $notification_type_id = $this->manager->get_notification_type_id($notification_type_name);
    $item_parent_id = isset($notification_data['item_parent_id']) ? $notification_data['item_parent_id'] : 0;

    /** @var \canidev\reactions\notification\post */
    $notification = $this->manager->get_item_type_class($notification_type_name);

    $sql = 'SELECT *
        FROM ' . $this->notifications_table . '
        WHERE notification_type_id = ' . (int)$notification_type_id . '
        AND item_id = ' . (int)$notification_data['item_id'] . '
        AND item_parent_id = ' . $item_parent_id;
    $result = $this->db->sql_query($sql);
    $notification_row = $this->db->sql_fetchrow($result);
    $this->db->sql_freeresult($result);

    if (!$notification_row || !$notification->allow_multiple_users())
    {
        return $this->manager->add_notifications($notification_type_name, $notification_data);
    }

    $notification_data = array_merge($notification_row, $notification_data);

    return $this->manager->update_notifications($notification_type_name, $notification_data, [
        'item_id' => $notification_data['item_id'],
        'item_parent_id' => $item_parent_id,
    ]);
}

And now every react sends a notification, but the "User1, user2, USer3 and x others reacted to your post" feature it's gone with this method.

But with this method every react -> sends a notification to the author with the latest person that reacted.

With the original add_notification method, there's a 40% chance that the notification is not sent.

I even tried with a new user to react to an old post that has not beed reacted to in more than 30 days, and the author did not recieve any notification for that post..